Code review comment for lp:~lifeless/bzr/subunit

Revision history for this message
Vincent Ladeuil (vila) wrote :

So. I've tested without subunit nor testtools => clean failure:

bzr: ERROR: No module named testtools
You may need to install this Python library separately.

We may want to polish things a bit on platforms where this may be harder to install, but nothing urgent.

I've tested with my current versions of subunit/testtools, horrible crashes :) The NEWS entry should
take care of that (I don't know how many people are currently using testtools/subunit and running
the test suite but they are likely to read the NEWS).

BUT, running with up-to-date versions is far too verbose for XFAILs, the traceback is nicely presented
thank you, I just don't want to see it when running with --parallel=fork.

I'm +1 for get_log() and renaming StreamWriter until your patch is accepted.

That being said, it's a pleasure to see many warts removed (don't tell me you need BZRTransformingResult
back to addres the above :0) , thanks for that.

I'll be running this branch on babune and comment later about the results.

review: Needs Fixing

« Back to merge proposal