Code review comment for lp:~lifeless/bzr/subunit

On Wed, 2009-12-16 at 21:00 +0000, Robert Collins wrote:
>
> > BUT, running with up-to-date versions is far too verbose for XFAILs,
> > the traceback is nicely presented
> > thank you, I just don't want to see it when running with
> > --parallel=fork.
>
> Oh, that was an unintended behavioural change, will fix. It is
> detecting
> it as xfail FWIW.

Hah! Brilliant!

Read the code for addExpectedFailure

it is *meant* to show the backtrace.

But it doesn't. Why? because it uses ui.ui_factory.note, and during the
execution of a test (which is when the current code reports things with
exceptions), ui.ui_factory is a SilentUIFactory.

Global State, I heart thee.

Oh, I've also been able to delete expectFailure, another helper thats in
the base class I missed.

-Rob