Code review comment for lp:~lifeless/bzr/test-speed

Revision history for this message
Vincent Ladeuil (vila) wrote :

This far better that what we had.

You give us a far cleaner TestRunner, so whatever is left appears bigger now:
- the loop on result_decorators to propagate a boolean looks highly suspicious,
- the injection of BZRTransformingResult is even more ugly than before, couldn't
  that be a result decorator now ?
- I still don't like that self.verbosity handling here, again, can't that
  be turned into a decorator ?

Given that this patch is a clear improvement, please land, the above can come later
(if you agree on them).

review: Approve

« Back to merge proposal