Code review comment for lp:~lifeless/launchpad/librarian

Revision history for this message
Robert Collins (lifeless) wrote :

> + # self.assertEqual(default_root, config.librarian_server.root)
>
> What's this for? Is it related to the unfinished comment somehow?

Oh, TDD recursion I hadn't quite popped out. It should work now, so
I'll uncomment it.

Actually this is still not ready; I've updated the comment:

- # This needs more sophistication in the config system (it needs to
- # affect configs on disk and other perhaps other processes
+ # This needs more sophistication in the config system (tearDown on
+ # the layer needs to pop the config fragment off of disk - and
+ # perhaps notify other processes that its done this. So for now we
+ # leave the new config in place).

« Back to merge proposal