Code review comment for lp:~lifeless/launchpad/malone

Revision history for this message
Robert Collins (lifeless) wrote :

Thanks for the feedback will do most of it.

I have a few quirks though:
 - matchers inline - i agree, but the noddy style guide line wrapping
rules make it ugly. If you agree that inline is better even so, I'll
move it inline and wrap it the way I would in every other python
project.

 - the flavor comment is there because its a deprecated API. I think
the deprecation is a mistake until we actually don't need it.

Thanks,
Rob

« Back to merge proposal