Code review comment for lp:~lifeless/launchpad/milestones

Revision history for this message
Curtis Hovey (sinzui) wrote :

MilestoneView._bugtasks uses precache_permission_for_objects() on the bugtasks and the conjoined bugtasks. Does this change allow us to remove precache_permission_for_objects()? Will your test fail if I remove precache_permission_for_objects() from the view?

MilestoneView._bugtasks calls getConjoinedMaster() with a prepared list (1 query) of expected ids. I think we need to keep behaviour; this branch just lowers the access cost of getConjoinedMaster()

review: Needs Information

« Back to merge proposal