Launchpad itself

Code review comment for lp:~lifeless/launchpad/milestones

  1. milestones
  2. Merge into devel
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Robert.

Thanks for this refactoring.

Can you place a comment before ``if False and True:`` in BugtaskSet.search() to explain the dagnostic output? I had to think about the old and new guard.

I think you can remove the naked taskset in BugTaskSet.searchBugIds(). I do not think it is being used.

review: Approve (code)

« Back to merge proposal