Code review comment for lp:~lifeless/launchpad/run

Revision history for this message
Robert Collins (lifeless) wrote :

Note that the changes to ignore should_launch are because some services deliberately ignore it - they don't run by default but when explicitly chosen they need to run; their 'should_launch' is defined as 'return False' : we already filter so that only wanted services are attempted, so checking for should_launch on setUp is a harmful (breaks consistency, causes more code) belts-and-braces.

« Back to merge proposal