Code review comment for lp:~lifeless/launchpad/run

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

166 + """kill process and BLOCK until process dies.

Should have an initial capital.

I also wonder if stop_process should get more forceful than TERM, but well, that's something for another branch.

The changes look nice, btw.

review: Approve

« Back to merge proposal