Code review comment for lp:~lifeless/subunit/nopassthrough

Revision history for this message
Jonathan Lange (jml) wrote :

> This adds --no-passthrough to most filers, which is useful for ensuring there
> is no noise in a stream. This is important for some uses, like when outputting
> structured data other programs will be reading.

Hey Rob,

This seems like a good feature & I can't fault the code. From the description in the MP though, I was expecting the behaviour to be that --no-passthrough makes the script error out when there is noise.

Perhaps the option should be 'discard-noise' or something similar?

jml

review: Approve

« Back to merge proposal