Code review comment for lp:~lifeless/testtools/0.9.1

Revision history for this message
Jonathan Lange (jml) wrote :

Ahh, I think this API is much more sensible, and wish I'd thought of this earlier.

 * In the NEWS file you say "sideffects" to mean "side effects"
 * In Mismatch.describe's docstring, "human readable" should say "human-readable"
 * I think saying "assertIsNot" is nicer than "assertNotEqual" when contrasting with None, but whatever.

Please feel free to land the patch after fixing the first two points.

review: Approve

« Back to merge proposal