testtools

Merge lp:~lifeless/testtools/details into lp:~testtools-committers/testtools/trunk

  1. details
  2. Merge into trunk
Proposed by Robert Collins
Status: Merged
Merged at revision: not available
Proposed branch: lp:~lifeless/testtools/details
Merge into: lp:~testtools-committers/testtools/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~lifeless/testtools/details
Reviewer Review Type Date Requested Status
testtools developers Pending
Review via email: mp+14613@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Its good. Let it in. Should be self explaining.

Revision history for this message
Jonathan Lange (jml) wrote :

The code quality is good, a couple of minor points.

 * Please add a comment explaining the reason for the guarded import. It's for Python compatibility, right?

 * There's a typo in the getDetails docstring. "detials".

 * Probably add a pointer to the addDetail pointing to the TestResult docs

 * I don't know how much I like using "detail" in the singular as a technical term for one of these things. I can't think of an alternative, so let's leave it for now. If you can think of something better, that'd be great. Please not "adsorb" though.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches