Code review comment for lp:~lifeless/testtools/details
Revision history for this message
| Jonathan Lange (jml) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
The code quality is good, a couple of minor points.
* Please add a comment explaining the reason for the guarded import. It's for Python compatibility, right?
* There's a typo in the getDetails docstring. "detials".
* Probably add a pointer to the addDetail pointing to the TestResult docs
* I don't know how much I like using "detail" in the singular as a technical term for one of these things. I can't think of an alternative, so let's leave it for now. If you can think of something better, that'd be great. Please not "adsorb" though.