Code review comment for lp:~lifeless/zope.testing/subunit
Revision history for this message
| Robert Collins (lifeless) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
On Tue, Jul 20, 2010 at 5:31 PM, Benji York <email address hidden> wrote:
> On Tue, Jul 20, 2010 at 11:15 AM, Robert Collins
> <email address hidden> wrote:
>> I agree there are tests missing; I don't see that holding improvements
>> of untested code hostage to tests is a good balance.
>
> I don't expect the patch to include all the missing tests, but a
> regression test would be appropriate. Since you produced the patch, I
> assume you can reproduce the behavior that the patch corrects.
No, I can't- I just know the API in question.