Code review comment for lp:~mabkenar/ubuntu-keyboard/add-persian-layout

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Hi Masoud,

 Overall this plugin looks great, just a couple of small things:

 * On my desktop system there's a key that doesn't render correctly on the bottom row (see http://i.imgur.com/NiHFGZB.png), so I think there's a font package we'll need to add as an additional dependency to the ubuntu-keyboard-persian package. Do you know which font is likely to provide this character?

 * I noticed that key isn't present on the email layout (but is there on the URL layout), is that intentional?

Thanks!

review: Needs Fixing

« Back to merge proposal