Code review comment for lp:~macslow/notify-osd/fix-396736

Revision history for this message
David Barth (dbarth) wrote :

Needs information or fixing, in that I'd like to see a unit test that shows that the regexp is equivalent to the gscanner thing, and also that it doesn't enter an infinite loop if the font name is weird (unset, or whatever).

The rest looks fine.

review: Needs Information

« Back to merge proposal