Code review comment for lp:~mandel/desktopcouch/batch_update

Revision history for this message
Manuel de la Peña (mandel) wrote :

The patch adds a put_records_batch method that puts a batch of docs in the db and a test that ensures that works as expected. The docs are added using a single request while the attachments are added one by one.

The result is a tuple of the form ``(success, docid, rev_or_exc)``, where ``success`` is a boolean indicating whether the update succeeded, ``docid`` is the ID of the document, and ``rev_or_exc`` is either the new document revision, or an exception instance (e.g. `ResourceConflict`) if the update failed.

Use case: Add a group of contacts to a category/tag

Concerns: If an attachment fails the doc are not rolled back. This same behavior if found in the single put_record method.

« Back to merge proposal