Code review comment for lp:~mandel/desktopcouch/fix_bug_519873

Revision history for this message
Chad Miller (cmiller) wrote :

"for index, current_value in enumerate(self):" is preferable to "index = 0", then "for current_value in..." and "index += 1" inside.

Also, I'm not too enthusiastic about restricting pop/remove on the last item. It's not a problem for lists to remove the last item. Perhaps we should destroy the container that must not be empty instead, when it reaches zero entries. Or, change the container so that it may be empty? (I do not understand the empty restriction yet.)

review: Needs Fixing

« Back to merge proposal