Code review comment for lp:~mandel/desktopcouch/fix_bug_519873

Revision history for this message
John O'Brien (jdobrien) wrote :

The code looks good but I get unrelated errors.

======================================================================
FAIL: test_get_my_host_unique_id
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 106, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/utils.py", line 191, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/home/john/canonical/ubuntuone/desktopcouch/fix_bug_519873/desktopcouch/pair/tests/test_couchdb_io.py", line 134, in test_get_my_host_unique_id
    self.assertEquals(got, again)
  File "/usr/lib/python2.6/dist-packages/twisted/trial/unittest.py", line 262, in failUnlessEqual
    % (msg, pformat(first), pformat(second)))
FailTest: not equal:
a = ['a0624880-6e12-4794-8010-32a973c43c8f']
b = ['5946ee98-d83f-479e-ba0f-3f88bfa11a6c']

review: Approve

« Back to merge proposal