Merge lp:~mars/launchpad/fix-ec2-email-encoding into lp:launchpad
Proposed by
Māris Fogels
| Status: | Merged |
|---|---|
| Approved by: | Gary Poster |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp:~mars/launchpad/fix-ec2-email-encoding |
| Merge into: | lp:launchpad |
| Diff against target: |
12 lines (+1/-1) 1 file modified
lib/devscripts/ec2test/testrunner.py (+1/-1) |
| To merge this branch: | bzr merge lp:~mars/launchpad/fix-ec2-email-encoding |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Poster (community) | Approve | ||
|
Review via email:
|
|||
Commit message
This branch fixes a UnicodeEncodeError raised by ec2test when using an email address that contains unicode characters.
Description of the change
This branch fixes a UnicodeEncodeError raised by ec2test when using an email address that contains unicode characters.
The fix encodes the unicode email address object to a UTF-8 binary string, which SFTP then handles correctly.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
[11:29am] gary_poster: mars, I'm guessing you have empirical proof it works?
[11:29am] mars: gary_poster, just a traceback from danilos sent to lp-dev. This same fix is present throughout the ec2test.py file.
[11:31am] mars: gary_poster, I have have danilos try it out before submitting to PQM
[11:32am] gary_poster: mars, alright. I have vague memories of pain with UTF in email headers and the stdlib email packages, but even if things don't get better, this shouldn't make anything worse (and hopefully it is a fix, of course!). Yes, would be happy if someone gave it a try before merging. Will approve with that condition, since you already have it planned.