Code review comment for lp:~mars/launchpad/fix-ec2-email-encoding

Revision history for this message
Gary Poster (gary) wrote :

[11:29am] gary_poster: mars, I'm guessing you have empirical proof it works?
[11:29am] mars: gary_poster, just a traceback from danilos sent to lp-dev. This same fix is present throughout the ec2test.py file.
[11:31am] mars: gary_poster, I have have danilos try it out before submitting to PQM
[11:32am] gary_poster: mars, alright. I have vague memories of pain with UTF in email headers and the stdlib email packages, but even if things don't get better, this shouldn't make anything worse (and hopefully it is a fix, of course!). Yes, would be happy if someone gave it a try before merging. Will approve with that condition, since you already have it planned.

review: Approve

« Back to merge proposal