Code review comment for lp:~mars/launchpad/fix-picker-result-parsing-487975

Hi,

This branch fixes the Picker widget's API result parsing code. This fixes bug
#487975, which prevented the "Assign Me" link in the picker widget from working
correctly.

I updated the picker parsing code so that is processes the result as Node
objects rather than raw DOM elements. This saves us some tree traversal code.
There was no error checking code before, and I did not add any myself. It would
require changes beyond an RC fix.

I did not include a windmill test for this feature due to release-critical time
constraints.

Tested on launchpad.dev
Bugs Windmill tests appear to pass.
I haven't run the Bugs JS unit test suite.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
   lib/canonical/launchpad/javascript/lp/picker.js

== JSLint notices ==

jslint: No problem found in
'/home/mars/canonical/lp-branches/fix-picker-result-parsing-487975/lib/canonical/launchpad/javascript/lp/picker.js'.

Maris