Launchpad itself

Merge lp:~matthew.revell/launchpad/bug-subscribe-help-bug-484297 into lp:launchpad

  1. bug-subscribe-help-bug-484297
  2. Merge into devel
Proposed by Matthew Revell
Status: Merged
Approved by: Gavin Panella
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~matthew.revell/launchpad/bug-subscribe-help-bug-484297
Merge into: lp:launchpad
Diff against target: 36 lines (+7/-4)
1 file modified
lib/lp/bugs/browser/bug.py (+7/-4)
To merge this branch: bzr merge lp:~matthew.revell/launchpad/bug-subscribe-help-bug-484297
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+18458@code.launchpad.net

Commit message

Adds a tool-tip to the 'subscribe yourself' and 'subscribe someone else' links on bug pages, which notes that subscribing to a bug means Launchpad will send you email. Bug 484297.

To post a comment you must log in.
Revision history for this message
Matthew Revell (matthew.revell) wrote :

Adds a tool-tip to the 'subscribe yourself' and 'subscribe someone else' links on bug pages, which notes that subscribing to a bug means Launchpad will send you email.

Revision history for this message
Matthew Revell (matthew.revell) wrote :

Lines 8/9 are where Gedit deleted trailing white space.

Revision history for this message
Gavin Panella (allenap) wrote :

This is a very nice new feature, beautifully implemented ;)

review: Approve
Revision history for this message
Gavin Panella (allenap) wrote :

Actually, 28s/bugs/bug.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/bugs/browser/bug.py'
--- lib/lp/bugs/browser/bug.py 2010-01-21 22:07:42 +0000
+++ lib/lp/bugs/browser/bug.py 2010-02-04 14:40:45 +0000
@@ -79,7 +79,7 @@
7979
80# Constant for the maximum bug heat we'll use for converting80# Constant for the maximum bug heat we'll use for converting
81# IBug.heat to ratio. In the future this should come from the DB.81# IBug.heat to ratio. In the future this should come from the DB.
82# The value must be a float 82# The value must be a float
83MAX_HEAT = 5000.083MAX_HEAT = 5000.0
8484
85class BugNavigation(Navigation):85class BugNavigation(Navigation):
@@ -220,12 +220,16 @@
220 else:220 else:
221 text = 'Subscribe'221 text = 'Subscribe'
222 icon = 'add'222 icon = 'add'
223 return Link('+subscribe', text, icon=icon)223 return Link('+subscribe', text, icon=icon, summary=(
224 'When you are subscribed, Launchpad will email you each time '
225 'this bug changes'))
224226
225 def addsubscriber(self):227 def addsubscriber(self):
226 """Return the 'Subscribe someone else' Link."""228 """Return the 'Subscribe someone else' Link."""
227 text = 'Subscribe someone else'229 text = 'Subscribe someone else'
228 return Link('+addsubscriber', text, icon='add')230 return Link(
231 '+addsubscriber', text, icon='add', summary=(
232 'Launchpad will email that person whenever this bugs changes'))
229233
230 def nominate(self):234 def nominate(self):
231 """Return the 'Target/Nominate for release' Link."""235 """Return the 'Target/Nominate for release' Link."""
@@ -980,4 +984,3 @@
980 html += '<img src="/@@/flame-bw-icon" />'984 html += '<img src="/@@/flame-bw-icon" />'
981 html += '</span>'985 html += '</span>'
982 return html986 return html
983