Code review comment for lp:~matthew.revell/launchpad/ppa-add-repo-help-492283

Revision history for this message
Gavin Panella (allenap) wrote :

This looks good.

There's a general problem with the help pages, in that they fail validation (no character encoding, no doctype). They work fine, but it would be nice to make them work a little better. Please can you file a bug along the lines of "inline help pages should validate". We can probably make lp.services.inlinehelp.browser.HelpFolder do the work for us.

review: Approve

« Back to merge proposal