© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am 08.01.2010 18:36, Matthew Revell schrieb:
>
> This is the first of two branches that fix a number of bugs in the Translations UI text and help, as identified by Matthew R and Danilo at UDS-L.
>
Thanks for doing these. They will certainly help translators and
reviewers in doing a better job.
> === added file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -0,0 +1,42 @@
> +<html>
> + <head>
> + <title>Example directory layout for translation files</title>
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
OK, these seem to be a problem, as we found out. Please see that you can
fix it and file a bug for the affected existing help pages.
> + </head>
> + <body>
> + <h1>Example directory layout for translation files</h1>
Good, clear explanation.
[...]
> === added file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -0,0 +1,59 @@
> +<html>
> + <head>
> + <title>Importing a .po file from upstream</title>
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + </head>
> + <body>
> + <h1>Importing a .po file from upstream</h1>
> +
> + <p>
> + Many projects have translation efforts outside of Launchpad. If
> + you help translate that project for Ubuntu, you should import the
> + upstream translations from time to time.
> + </p>
This is also true for any other project that is not hosted on Launchpad
completely and for any other distribution hosted in LP. Can you find a
way to put it that broadens the meaning while still mentioning Ubuntu
(where this is particularly important)?
> +
> + <h2>How Launchpad prioritises imported translation strings</h2>
> +
> + <p>To help ensure the best quality translations end-up in Ubuntu,
just "end up", AFAIK.
Again, not just Ubuntu.
> + Launchpad prioritises translation strings differently depending
> + on where they were made.
> + </p>
> +
> + <p>
> + In general, a translation made in Launchpad will take precedence
[...]
Good explanation of a difficult matter. Well done. ;)
> === added file 'lib/lp/
OK.
> === added file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -0,0 +1,42 @@
> +<html>
> + <head>
> + <title>Reviewing translations<
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + </head>
> + <body>
> + <h1>Reviewing translations</h1>
> +
> + <p>
> + As a member of one or more translation groups, you can help make
> + sure that that the work of other translators makes it into
> + published software.
> + </p>
This should read "member of on ore more translation teams". A team is
assigned to a specific language for a specific project through the use
of a translation group.
Also, I feel that the community aspect should be stressed more. It's not
just about joining a team, it's also about interacting with the other
team members, splitting up the work and discussing and agreeing on
translations standards.
> +
> + <p>
> + All you need to do is review a few translated strings, every now
"All you need to do" sounds very casual, like it's an easy task (which
it is not). I guess you want to stress that the reviewer can chose his
own work pace etc, which is mostly true. But wait until the next Ubuntu
release draws near ... ;-)
> + and then, in the languages with which you're familiar. The more
> + reviews you do, the more software will be available in the
> + languages you care about.
> + </p>
> +
> + <p>
> + To get started, simply follow the review links on your
> + <a href="https:/
> + translation dashboard</a>.
> + </p>
> +
> + <p>
> + <strong>
Yes, very important! Maybe this should be at the top of the page?
> + overall guidelines set by the translation group, and any specific
> + to that language, before you start reviewing. Take a look at the
> + <a href="/+groups/" target=
> + page</a> for links to the guidelines.
> + </p>
> +
> + </body>
> +</html>
>
> === added file 'lib/lp/
Good explanation, thank you.
> === modified file 'lib/lp/
Good.
> === modified file 'lib/lp/
Good.
> === modified file 'lib/lp/
[...]
> +
> + <p>
> + The files you upload will be reviewed by an admin before they appear
> + in Launchpad.
> + </p>
> +
We only review templates. We rarely look at translation files, usually
only if some-one complains.
You do have a few overly long lines in there, I am surprised Tom did not
complain about them. The line length limitation is somewhat eased up for
HTML files but not gone completely ... ;-)
I ma marking this as need-fixing so we can come back tomorrow and talk
about the issues I mentioned.
review needs-fixing
Thanks you for this branch.
Henning
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkt
tGUAniA+
=Tf8P
-----END PGP SIGNATURE-----