Code review comment for lp:~maxb/launchpad/ignored-asserts
Revision history for this message
| Max Bowsher (maxb) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Nice catch! I like it. You should add this check to bin/lint.sh so that make
> lint will pick up this error for us.
Graham,
Are you sure you really want bin/lint.sh to depend on having a python2.6 installed?
In any case, once Launchpad properly migrates to Python 2.6 in the future, Python itself will be linting this.
Though, I guess this is "Needs fixing" anyway, since we need to resolve that Soyuz test failure before this branch can land. Should we aim to fix the soyuz test first, or to land this branch with the soyuz asserts commented out and XXXed?