Code review comment for lp:~maxb/launchpad/use-hashlib

Revision history for this message
Max Bowsher (maxb) wrote :

This somehow ended up with this in ec2test, despite working fine in plain old make check locally:

Error in test testAptSHA256 (lp.archivepublisher.tests.test_publisher.TestPublisher)
Traceback (most recent call last):
  File "/usr/lib/python2.5/unittest.py", line 260, in run
    testMethod()
  File "/var/launchpad/test/lib/lp/archivepublisher/tests/test_publisher.py", line 804, in testAptSHA256
    text, file = _getSHA256("foobar")
  File "/var/launchpad/test/lib/lp/archivepublisher/tests/test_publisher.py", line 797, in _getSHA256
    file = hashlib.sha256(open(test_filepath)).hexdigest()
TypeError: sha256() argument 1 must be string or read-only buffer, not file

Back to "Work in progress" whilst I try to figure out why.

« Back to merge proposal