Merge lp:~mbp/bzr-usertest/trivial into lp:~bzr/bzr-usertest/trunk-old

Proposed by Martin Pool
Status: Merged
Approved by: Robert Collins
Approved revision: 154
Merge reported by: Ian Clatworthy
Merged at revision: not available
Proposed branch: lp:~mbp/bzr-usertest/trivial
Merge into: lp:~bzr/bzr-usertest/trunk-old
Diff against target: None lines
To merge this branch: bzr merge lp:~mbp/bzr-usertest/trivial
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Ian Clatworthy Pending
Review via email: mp+7532@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

This adds some help and gives better messages in two error cases.

Revision history for this message
Robert Collins (lifeless) wrote :

+1

review: Approve
Revision history for this message
Robert Collins (lifeless) wrote :

Martin, I think you should just land this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '__init__.py'
--- __init__.py 2009-02-26 09:44:53 +0000
+++ __init__.py 2009-02-27 06:49:30 +0000
@@ -1,4 +1,4 @@
1# Copyright (C) 2007 Canonical Ltd1# Copyright (C) 2007, 2009 Canonical Ltd
2#2#
3# This program is free software; you can redistribute it and/or modify3# This program is free software; you can redistribute it and/or modify
4# it under the terms of the GNU General Public License as published by4# it under the terms of the GNU General Public License as published by
@@ -397,9 +397,14 @@
397class cmd_usertestcompare(Command):397class cmd_usertestcompare(Command):
398 """Generate a comparison report on csv data produced by userteststats.398 """Generate a comparison report on csv data produced by userteststats.
399 399
400 The CSV files must have names of the form $tool-$suite-$scenario.csv400 The CSV files must have names of the form $tool-$suite-$scenario.csv:
401 (where the components do not contain dashes) and the suite name corresponds401
402 to the usertest suite used to generate the data, e.g. "common" or "log".402 * $tool is the name of the tool used in the run, like "bzr-1.12". It
403 may optionally have a version, separated by a dash.
404 * $suite is the usertest suite used to generate the data, e.g. "common"
405 or "log"; it must not contain a dash.
406 * $scenario is an arbitrary name for the scenario being tested, again
407 containing no dashes.
403 """408 """
404 hidden = True409 hidden = True
405 takes_args = ['csv_files+']410 takes_args = ['csv_files+']
406411
=== modified file 'suiterunner.py'
--- suiterunner.py 2009-02-23 04:17:18 +0000
+++ suiterunner.py 2009-02-27 06:52:34 +0000
@@ -24,7 +24,7 @@
24import sys24import sys
25import time25import time
2626
27from bzrlib.trace import info, warning, error27from bzrlib.trace import info, warning, error, log_exception_quietly
28import archiveutil28import archiveutil
29import datadump29import datadump
30import dirutil30import dirutil
@@ -58,7 +58,7 @@
58 try:58 try:
59 module = __import__(module_name, globals(), locals())59 module = __import__(module_name, globals(), locals())
60 except ImportError, e:60 except ImportError, e:
61 # TODO: log exception properly61 trace.log_exception_quietly()
62 info("failed to find module %s\nerror: %s" % (module_name, e))62 info("failed to find module %s\nerror: %s" % (module_name, e))
63 return None63 return None
64 else:64 else:
@@ -66,7 +66,7 @@
66 module = getattr(module, part)66 module = getattr(module, part)
67 fn = getattr(module, 'script_suite', None)67 fn = getattr(module, 'script_suite', None)
68 if fn is None:68 if fn is None:
69 # TODO: log exception properly69 trace.log_exception_quietly()
70 info("failed to find script_suite() in %s" % module)70 info("failed to find script_suite() in %s" % module)
71 return None71 return None
72 return fn()72 return fn()

Subscribers

People subscribed via source and target branches

to all changes: