Code review comment for lp:~mbp/bzr/2.0-262450-backup-permissions

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/2.0-262450-backup-permissions into lp:bzr/2.0.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #262450 backup.bzr directory is world readable
> https://bugs.launchpad.net/bugs/262450
>
>
> Backport fix for bug 262450: backup.bzr should have the same permissions as the original repository.
>

We're switching:

+class _PosixPermissionsFeature(Feature):
+
...
+
+PosixPermissionsFeature = _PosixPermissionsFeature()

to:

class PosixPermissionsFeature(Feature):

posix_permissions_feature = PosixPermissionsFeature()

in bzr.dev (or at least trying to). It probably wouldn't hurt to do so
here. (though if this is a strict backport, I guess we missed that)

Otherwise:

 merge: approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkug6nsACgkQJdeBCYSNAAN1TACgxa+ln0DCmbK/14KoPTfSG8PS
Z7AAnR6IEVZAEJd6Yd2Rx1RGuXRVVx+O
=2WO9
-----END PGP SIGNATURE-----