Code review comment for lp:~mbp/bzr/340394-encoding-option

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Review: Needs Information
> This doesn't make sense: why would we want to have an output encoding that isn't compatible with the operating systems encoding? I'm channelling Martin[gz] here I think - I recall him asking this question in IRC, and I think its a good question.

Incorrect auto-detection. (Fairly common, Mac hasn't traditionally
detected well, neither FreeBSD, etc.)

Output to a file.

bzr log | less
  vs
bzr log > content.txt

(On Windows, the former should probably use Terminal encoding, but the
later should use locale.getpreferredencoding())

I think the big thing is having this as a step along the way to being
able to supply it on a per-command basis.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwfbKAACgkQJdeBCYSNAANDyACggTDoJffExuFR7Rkrj6X0CxZi
3B8AoI06keflVw93Ppezw6p++KQx/yrV
=DM/S
-----END PGP SIGNATURE-----

« Back to merge proposal