Code review comment for lp:~mbp/bzr/340394-encoding-option

On 23 June 2010 05:01, Robert Collins <email address hidden> wrote:
> On Tue, Jun 22, 2010 at 6:58 PM, Martin Pool <email address hidden> wrote:
>>> Incorrect auto-detection. (Fairly common, Mac hasn't traditionally
>>> detected well, neither FreeBSD, etc.)
>>
>> It is a good question.  Beyond the cases John mentions I just might
>> want the output in some arbitrary encoding: I might always work in
>> 8859-7 but want to export a diff as utf-8 to attach it to a Launchpad
>> bug.
>
> I don't see that particular one as relevant because the OS
> autodetection permits changing that via the existing standard
> environment variables already - or am I missing something? [possibly
> the variables are too big a hammer and the diff won't generate from
> disk correctly if the variables are changed?]

It's a few things:

 * eventually I want to have a command line option that rebinds these
variables for the scope of a process
 * I'm not sure if it's easy to change this from the windows command line
 * OS autodetection is sometimes wrong
 * you might want to set things on a finer granularity, for example
the unix path encoding, and these are not well exposed

--
Martin