Code review comment for lp:~mbp/bzr/391411-reconfigure-stacked

Revision history for this message
Martin Pool (mbp) wrote :

2009/7/15 Martin Pool <email address hidden>:

>> I don't think RepositoryBase is needed. Thats what Repository is.
>
> It would be nice if Repository was actually the base.  At the moment
> RemoteRepository does not inherit from it, and there seems to be some
> amount of copy-and-paste between them because of this.  Perhaps that
> should be a separate bug and I should continue the copy/paste for now.

I may be wrong but I anticipate some trouble if I change this; I
recall Spiv talking for a while about whether it should be a subclass
or not...

--
Martin <http://launchpad.net/~mbp/>

« Back to merge proposal