On Tue, 2009-07-14 at 23:48 +0000, Martin Pool wrote:
>
> > It would be nice if Repository was actually the base. At the moment
> > RemoteRepository does not inherit from it, and there seems to be
> some
> > amount of copy-and-paste between them because of this. Perhaps that
> > should be a separate bug and I should continue the copy/paste for
> now.
>
> I may be wrong but I anticipate some trouble if I change this; I
> recall Spiv talking for a while about whether it should be a subclass
> or not...
Spiv and I have repeatedly lamented them not being subclasses; however
we haven't had time to make it so. It may be easy.
On Tue, 2009-07-14 at 23:48 +0000, Martin Pool wrote:
>
> > It would be nice if Repository was actually the base. At the moment
> > RemoteRepository does not inherit from it, and there seems to be
> some
> > amount of copy-and-paste between them because of this. Perhaps that
> > should be a separate bug and I should continue the copy/paste for
> now.
>
> I may be wrong but I anticipate some trouble if I change this; I
> recall Spiv talking for a while about whether it should be a subclass
> or not...
Spiv and I have repeatedly lamented them not being subclasses; however
we haven't had time to make it so. It may be easy.
-Rob