Code review comment for lp:~mbp/bzr/430529-extension-warnings

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Review: Approve
>> You now get just this:
>>
>> mbp@lithe% ./bzr st
>> default2a plugin set default format to 2a
>> unknown:
>> bzrlib/tmp.diff
>> bzr: warning: some compiled extensions could not be loaded; see <https://answers.launchpad.net/bzr/+faq/703>
>
> That looks a lot nicer. Using a FAQ is ok, but it might be nicer to make
> a small help topic for it instead; that way it will be present on the
> users machine even if they are offline.
>
> review +1
>

Aren't you missing a:
trace.mutter('Some extensions failed to load:\n%s'
             % ('\n '.join(_extension_load_failures,))

At least, in the FAQ you say that the failures are in ~/.bzr.log. Maybe
they are there when they are first imported? It might be nice to have a
simple summary at the end.

I agree that it would probably be better as a help topic.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqyKykACgkQJdeBCYSNAANRxgCeLEPSAHcNZ9uhjjVIly7sualI
mSAAn0QGSB6qEmtN2XAQebdpfJNAJAtE
=gJTX
-----END PGP SIGNATURE-----