Code review comment for lp:~mbp/bzr/430529-extension-warnings

2009/9/17 John A Meinel <email address hidden>:
> Aren't you missing a:
> trace.mutter('Some extensions failed to load:\n%s'
>             % ('\n    '.join(_extension_load_failures,))
>
> At least, in the FAQ you say that the failures are in ~/.bzr.log. Maybe
> they are there when they are first imported? It might be nice to have a
> simple summary at the end.

That's done at the time the exception originally occurs.

> I agree that it would probably be better as a help topic.

You may be right. I put it here for a couple of reasons:

 - A help topic about 'c extensions' seems like it out to have a
larger scope than just how to deal with this warning and I didn't want
to write that today :-)
 - In general I'm wondering if advice to users should be moved onto the web

--
Martin <http://launchpad.net/~mbp/>