Code review comment for lp:~mbp/bzr/497274-http-405

Revision history for this message
Martin Pool (mbp) wrote :

@vila: How do you see the interaction between the various http exception classes working. For instance, why is this code as it is:

    def http_error_default(self, req, fp, code, msg, hdrs):
        if code == 403:
            raise errors.TransportError(
                'Server refuses to fulfill the request (403 Forbidden)'
                ' for %s' % req.get_full_url())
        else:
            raise errors.InvalidHttpResponse(req.get_full_url(),
                                             'Unable to handle http code %d: %s'
                                             % (code, msg))

« Back to merge proposal