Code review comment for lp:~mbp/bzr/497274-http-405

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> martin> I guess I don't properly understand whether you think
> martin> my patch is actually wrong or just needs tests. I
> martin> will try to use your tests with mine and see where we
> martin> get to.
>
> I hope I clarified that: except for 404, I'm fine with a common
> error handling, may be I just haven't seen yet a good way to
> implement that but I didn't spend much time on it either and I
> trust you to find it ;)
>

If the only code that uses 404 specially is HEAD, then I would be happy
to have it trap the exception. #1 because I don't think we use
"transport.has*" in any live code path. LBYL vs EAFTP.

I think the only code that uses it is probably old-format repositories.
(Where having a revision was indicated by the presence of the
'.bzr/revisions/$REVID' file.)

I'm pretty sure everything else would treate 404 as NoSuchFile.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksvi9wACgkQJdeBCYSNAAM7ygCffCBwDol9uBmR8XgrlxnQTe1e
vOMAoKCYRxzzy7RQmM+Byq7iKO7EP0VF
=dmsP
-----END PGP SIGNATURE-----