Code review comment for lp:~mbp/bzr/doc

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/doc into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #512385 Broken link to "quick start card" in online user guide
> https://bugs.launchpad.net/bugs/512385
>
>
> This fixes urls in the docs and source
>
> * bazaar-vcs.org -> bazaar.canonical.com
> * wiki pages on there to wiki.b.c.c
> * spanish docs should link to the spanish top-level page
> * some other small corrections
>
> It doesn't change most uses of our url as test data.
>
> The change is not just mechanical so please read it carefully.
>
> thanks
>

+Ready-to-install packages are available for most popular operating
systems from
+<http://www.bazaar.canonical.com/Download/> or you can install from
source by
+following the instructions in the INSTALL file.

^- http://wiki.bazaar.canonical.com/Download

=== modified file 'doc/es/_templates/layout.html'
- --- doc/es/_templates/layout.html 2009-10-30 07:51:16 +0000
+++ doc/es/_templates/layout.html 2010-01-29 10:56:19 +0000
@@ -1,9 +1,9 @@
 {% extends "!layout.html" %}

 {% block rootrellink %}
- -<li><a href="http://bazaar-vcs.org/">
+<li><a href="http://bazaar.canonical.com/">
     <img src="{{ pathto("_static/bzr icon 16.png", 1) }}" />
Inicio</a>&nbsp;|&nbsp;</li>
- -<a
href="http://doc.bazaar-vcs.org/en/">Documentación</a>&nbsp;|&nbsp;</li>
+<a
href="http://doc.bazaar.canonical.com/es/">Documentación</a>&nbsp;|&nbsp;</li>

^- There is no: http://doc.bazaar.canonical.com/es/
Not sure what to do with that. Are we just missing a step in the build
process. The /ru change seems to be correct, though.

I checked all the other links, and they seem ok.

 review: needs_fixing
 merge: approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktiwMIACgkQJdeBCYSNAAPk9QCgwZurXUdjAPcHi5fINksAVYnV
F4kAnjoIaWKhy/wMkoFW0AcTQbkkmv5h
=THDk
-----END PGP SIGNATURE-----

review: Needs Fixing

« Back to merge proposal