Code review comment for lp:~mbp/bzr/doc

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> Martin Pool <email address hidden> writes:

    > On 7 July 2010 11:01, John A Meinel <email address hidden> wrote:
    >> I think 'all_proxy' is used for both http, https and ftp. 'no_proxy'
    >> allows you to have a 'match everything' http proxy, except for
    >> internal-only websites, etc.

Correct.

    > I didn't want to add ftp_proxy or all_proxy etc because I'm not sure
    > that they actually do work for all protocols with bzr. Perhaps they
    > actually do.

I don't think the ftp transport (via ftplib) respect that (quick search
for proxy in ftplib confims that).

So intead of 'Perhaps they actually do' may be its 'Perhaps they
actually should' :-/

         Vincent

« Back to merge proposal