Code review comment for lp:~mbp/bzr/initialize

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/initialize into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #507710 want bzrlib.initialize() to do all typical setup
> https://bugs.launchpad.net/bugs/507710
>
>
> This adds a bzrlib.initialize function for the benefit of other applications using bzrlib, so that they don't need to know every particular component that needs to be initialized.
>
> This may also be an easier place to do initialization than in code that runs at import time.
>

This
 install_bzr_command_hooks()

Is still something that wrappers need to run before the have access to
the command infrastructure. Otherwise, AFAICT this covers all the stuff
that I would normally try to set up manually. (I'm just trying to
remember the various things that stuff like loggerhead has run into
trying to call into bzrlib.)

 merge: approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktyQjsACgkQJdeBCYSNAAOZ+wCfWE++nWxOsztbLhCauR8ByCln
dgAAn0w/vR0BDc9HXOOiRDBOijHl41C6
=pFMi
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal