Code review comment for lp:~mbp/bzr/remove-controlfiles

Revision history for this message
Martin Pool (mbp) wrote :

> The only question in whether '.control_files' is part of the Branch api, and thus needs to be deprecated rather than just removed.

It probably does count of part of the api. I think it probably shouldn't be, because it's not any particularly distinct part of it, just a historic implementation detail. It probably should be specifically removed.

However our machinery for doing deprecations on things like this that can be called publicly, overridden, and also up-called is a bit weak.

« Back to merge proposal