Code review comment for lp:~mbp/bzr/remove-logging

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2009-12-02 at 01:58 +0000, Martin Pool wrote:
>> See also https://bugs.edge.launchpad.net/bzr/+bug/317779
>>
>> @lifeless I'll try to redraft this to not change any blackbox behaviour.
>
> Thanks, muchly appreciated.
>
>> The FormatDeprecationWarning test was strictly redundant with another test.
>
> oh cool.
>
> Rob
>

I should note that paramiko makes extensive use of the python logging
infrastructure. If we don't set up a default logging setup then paramiko
trying to log stuff will print out "unable to get default logging" or
whatever that error message is.

I haven't looked if Martin's changes actually effect this, but I figured
I'd mention it.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksWnrIACgkQJdeBCYSNAAPQxQCgtdbSaEyaIbMLiPl/L7LDO3no
h1kAoJ2zB5w9b0MOxWgY/CasDKHqZ22+
=u1LZ
-----END PGP SIGNATURE-----

« Back to merge proposal