Code review comment for lp:~mbp/bzr/remove-logging

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

A bunch of minor things in trace.py need tweaking (see below) but my main concern is --quiet support. IIUIC, note messages are no longer suppressed if --quiet is passed which is wrong. A simple if test added to note() ought to fix it?

trace.py things ...

1. no need to import itself

2. enable_default_logging() stuff:
   * docstring refers to _push_log_file, not push_log_file
   * result variable set but never used

3. the API change to pop_log_file() ought to be mentioned in NEWS

Otherwise, this looks good. Well done!

review: Needs Fixing

« Back to merge proposal