Code review comment for lp:~mbp/launchpad/683486-build-mailman

Revision history for this message
Barry Warsaw (barry) wrote :

Sorry, I'm just now seeing this mp. I don't know why the normal build process isn't completing the monkeypatching, and it's been a long while since I looked at the Launchpad build process, but one thing you can (or maybe *could*) do was 'make SHHH= ' to see verbose output. I'm betting that in some circumstances, a failure earlier up will be visible and that should help explain why the monkey patching doesn't happen.

In any case, this extra backup of a test should be fine. Thanks for looking into this Martin.

review: Approve

« Back to merge proposal