Code review comment for lp:~mbp/launchpad/dkim

Revision history for this message
Martin Pool (mbp) wrote :

bug 587783 now has what I think is a good clean patch, and a script to demonstrate it, and I've just sent it upstream.

There is also a source package branch there that can build a .deb of the fixed version or I guess that can be turned into an egg if prefered.

There was some list discussion of this <https://lists.launchpad.net/launchpad-dev/msg03533.html>

The point was also raised that we might want a whitelist of domains who are trusted to have meaningful DKIM headers, so I'll add that and do stub's tweaks.

« Back to merge proposal