Code review comment for lp:~mbp/launchpad/dkim

Revision history for this message
Martin Pool (mbp) wrote :

A couple more things:

 * We need to check the From address matches the signature; at the moment we don't but I now have a failing test for it
 * python-dkim only checks the first signature so a multiply signed message may be seen as untrusted. I think this is fine for now.

« Back to merge proposal