Hi, Martin.
Welcome to Launchpad development! :)
This looks nice. It's a small change with a nice benefit.
I don't want to be too nit-picky about such a small diff, but our style guidelines would have us format the function call differently:
ui.ui_factory = ui.make_ui_for_terminal( sys.stdin, sys.stdout, sys.stderr)
See https://dev.launchpad.net/PythonStyleGuide#Multiline%20function%20calls.
Other than this very minor thing, it looks ready to land. Thanks again!
Cheers, deryck
« Back to merge proposal
Hi, Martin.
Welcome to Launchpad development! :)
This looks nice. It's a small change with a nice benefit.
I don't want to be too nit-picky about such a small diff, but our style guidelines would have us format the function call differently:
ui.ui_factory = ui.make_ ui_for_ terminal(
sys.stdin, sys.stdout, sys.stderr)
See https:/ /dev.launchpad. net/PythonStyle Guide#Multiline %20function% 20calls.
Other than this very minor thing, it looks ready to land. Thanks again!
Cheers,
deryck