Code review comment for lp:~michael.nelson/launchpad/211008-visual-indicator-superseded-pkgs

Revision history for this message
Michael Nelson (michael.nelson) wrote :

= Summary =

Ensures that if a package in a PPA has been superseded by later version of the same package in the distroseries primary/partner archive, then it will be indicated in the PPA UI.

== Proposed fix ==

Add ISourcePackagePublishingHistory.newer_distroseries_version and use this in the template to add a link to the newer version as well as highlight the row subtly with a gray background.

== Pre-implementation notes ==

See comments on bug 211008 (I did some UI pre-imp there). Note, I ended up removing the icon altogether as it was not subtle at all.

== Implementation details ==

== Tests ==
bin/test -vv -t doc/publishing.txt -t xx-ubuntu-ppas.txt

== Demo and Q/A ==

To demo:
 1. visit https://launchpad.dev/~cprov/+archive/ppa
 2. In a `bin/iharness` run the following script:
http://pastebin.ubuntu.com/338780/
 3. Reload https://launchpad.dev/~cprov/+archive/ppa
 4. Click on 'View package details' and see the same change there also.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt
  lib/lp/soyuz/model/publishing.py
  lib/lp/soyuz/doc/publishing.txt
  lib/lp/soyuz/templates/sourcepackagepublishinghistory-listing-archive-detailed.pt
  lib/lp/soyuz/interfaces/publishing.py
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/soyuz/templates/archive-index.pt

== Pylint notices ==

lib/lp/soyuz/interfaces/publishing.py
    33: [F0401] Unable to import 'lazr.enum' (No module named enum)
    40: [F0401] Unable to import 'lazr.restful.fields' (No module named restful)
    41: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful)

« Back to merge proposal