Code review comment for lp:~michael.nelson/launchpad/219222-edit-ppa-dependencies-rename

Revision history for this message
Michael Nelson (michael.nelson) wrote :

= Summary =

This branch fixes bug 219222 simply by renaming 'Edit dependencies' to
'Edit ppa dependencies'.

http://people.canonical.com/~michaeln/tmp/edit-dependencies-link.png

I also used the opportunity to get rid of the old pagetitles.py entry
and update the related view with the label/page_title.

http://people.canonical.com/~michaeln/tmp/edit-dependencies-heading.png

My main concern is that this makes the action text quite long - meaning
that it wraps when the window is not reasonably wide. Actually, I think
my concern is more generally with *how* those actions with icons wrap
across LP generally - it'd be much nicer if the wrapped line aligned
with the RHS of the icon.

== Tests ==

bin/test -vv -t archive-views.txt -t xx-edit-dependencies.txt

== Demo and Q/A ==

Log in as <email address hidden>:test and visit:

https://launchpad.dev/~cprov/+archive/ppa

Click on 'Edit PPA dependencies'.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/soyuz/browser/tests/archive-views.txt
  lib/lp/soyuz/templates/archive-edit-dependencies.pt
  lib/lp/soyuz/stories/ppa/xx-edit-dependencies.txt
  lib/lp/soyuz/browser/archive.py

--
Michael

« Back to merge proposal