Code review comment for lp:~michael.nelson/launchpad/219222-edit-ppa-dependencies-rename

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Michael,

nice work! just one nitpick:

> @@ -39,12 +39,13 @@
> ... auth='Basic <email address hidden>:test')
> >>> no_priv_browser.open("http://launchpad.dev/~no-priv/+archive/ppa")
>
> - >>> no_priv_browser.getLink('Edit dependencies').click()
> + >>> no_priv_browser.getLink('Edit PPA dependencies').click()
> >>> print no_priv_browser.url
> http://launchpad.dev/~no-priv/+archive/ppa/+edit-dependencies
>
> >>> print no_priv_browser.title
> - Edit dependencies for PPA for No Privileges Person...
> + Edit PPA dependencies : PPA for No Privileges Person :
> + No Privileges Person
>
> Only Celso and an administrator can access the 'Edit dependencies'
> page for Celso's PPA.

Not really important, but could you you s/'Edit dependencies'/'Edit PPA dependencies' ?

review: Approve

« Back to merge proposal